• Personal achievements

  • Documentation contribution #11762 Remove helm installation guide and Add helm documentation link (opens in a new tab)

    • We need to install helm for MinIO configuration, but the helm installation guide only shows the configuration related to mac, so we fixed it to access the helm official documentation.

  • Documentation contribution #11735 Add installation option description (opens in a new tab)

    • We added a detailed description of the managed namespace option.
    • I learned from a maintainer that there is a Documentation convention (opens in a new tab) for Kubernetes here.

  • Contribution Preparation Courses and Activities

    • Learn the basics of Github
      • My mentor gave me an assignment to update my profile. I familiarized myself with the concepts of GPG and DCObot to become more familiar with github.
    • Docker Beginner Special Class
      • We had an activity to create a docker image using Dockerfile. I learned the concepts by reading the materials organized by my mentor. In addition, when creating the image, I tried to apply multi stage build (opens in a new tab) to include only the features needed for execution.
      • After the lab, my mentor walked me through Overlay FS (opens in a new tab) one by one, showing me how the images are created. This was really informative...
    • Learning the basics of Kubernetes
      • Before contributing, I took the time to study the basics of Kubernetes.
        • 개인 공부자료 (opens in a new tab)
    • Argo workflows
      • template and self-study (opens in a new tab).
      • Mentee Hakjun showed me the pipeline for deploying on GCP using ArgoCD and Argo Workflows (opens in a new tab).

  • Participation in OSS meetup activities

    • Mentors and mentees gave presentations on various topics. It was a good time to hear what problems they are facing in the real world besides contributing and how they solved them.

  • Participating in the hackathon

    • Mentee Sungrak helped me a lot. He shared the issues he thought were okay and always encouraged me to challenge myself.
    • He recommended the issue #11609 Compile expr in config (opens in a new tab), so I tried it.
    • I spent some time analyzing the issue by teaching myself Golang (opens in a new tab).
    • It was a good time to become more familiar with golang.

• 1 issue, 3 PRs
• Modified GitHub Actions log name to improve readability
  • https://github.com/argoproj/argo-workflows/pull/11670 (opens in a new tab)
  • Among the steps performed in publish-release, Run actions/cache@v3 is performed a total of three times.
  • Each person has a different role, but the same name is used, so the part where it may feel like the same task is being done three times has been changed to a name that fits each role.
• Delete cache logic that does not require GitHub Actions
  • https://github.com/argoproj/argo-workflows/pull/11754 (opens in a new tab)
  • Fixed an error that occurred due to overlapping cache because caching is performed by default unless the cache option is set to false in setup-go actions.
• Upgrade all checkout@v3 that uses the deprecated NodeJS 16 version to checkout@v4.
  • https://github.com/argoproj/argo-workflows/pull/11782 (opens in a new tab)
  • Since NodeJS will soon end its security support, changes have been made to use actions using the latest version.

[Project Contributions]

1. 'Bug modification' Argo Workflow Datpicker improvement (completed)

Improve the ui of datepick, one of the filter functions of the workflow list page

Issue Link

UI: Datepicker Style Malfunction Issue · Issue #11476 · argoproj/argo-workflows (opens in a new tab)

PR Link

fix: Datepicker Style Malfunction Issue. Fixes #11476 by zel0rd · Pull Request #11480 · argoproj/argo-workflows (opens in a new tab)

2. 'Bug modification' Cronworkflow's State filter initial value setting (completed)

Fixed a bug where the status filter in the cronworkflow is rendered regardless of the initial value

Issue Link

ui: Cron workflow initial filter value · Issue #11685 · argoproj/argo-workflows (opens in a new tab)

PR Link

https://github.com/argoproj/argo-workflows/pull/11686 (opens in a new tab)

3. 'Fix the bug' Remove webpack-related alerts from the initial page (in progress)

To remove web pack monitoring that occurs when loading argo workflow ui

Currently testing the dependence and functionality of the associated libraries

4. 'Improvement' Improvement of login page (in progress)

Issues that improve the existing login page in Argo Workflow in the same form as the Argo CD

We will analyze the login capabilities provided by current workflow and apply new designs and designs afterwards

Issue Link

Similar login page to Argo CD · Issue #10816 · argoproj/argo-workflows (opens in a new tab)

[Project Activity History]

7.8 Opening Ceremony (Project Introduction and Self-Introduction)

• Opening ceremony
• Time for self-introduction using nicknames
• A rough introduction to the project
• a majority vote for the rules of gathering activity
  • The next meeting activity will be held from 1 p.m. on Saturday (07/15) unlike the regular schedule, depending on the majority vote of the participants at the opening ceremony. The planned activity topic is:
  • Time to review or talk about *common activities** for the next week
  • Time to communicate about topics of interest
  • You can also set up the development environment according to your progress. (Optional)
  • (Common activities will be organized and shared within tomorrow's work hours.)

7.15 First Meeting (Introduction to Development Environment Settings and Workflow Features)

• Open Up to the First Meeting
• Development Environment Settings (dev-container)
• Playground Mission (DCO Bot Check Passed, Commit Using GPG, Commit Message Convention)
  • I created a playground before I immediately challenged a real open-source project. The first goal is to do issues/PR/commitments, etc., from an outsider's perspective on the project in this Playground. It's simple, but there may be unexpected gateways for the first time, so please focus. If we resolve the first issue early, we will give you additional instructions. Haha
  • 저장소: https://github.com/ArgoWorkflows-OSS/ArgoWorkflows-OSS (opens in a new tab)
  • Objective: Select member profile update issue in issue template and generate first PR according to issue content.

7.23 Second meeting (share issues of interest)

• Gathering at Seongsu to conduct the second meeting (provided by Musinsa-Andahye Mentee)
• Introduce issues of interest, share issues with each other

8.6 Fourth meeting

Presentation activities

• argo event와 workflow, cd연동
• eBpf

8.13 Fifth Meeting

Presentation activities

• webRTC

8.20 6th Meeting

presentation activityEast

• Platform builder & K6 load test PoC for developers to load test themselves

[Project Activities]

1. [Learning to contribute]
   1. Kubernetes Architecture Lecture - YouTube link (opens in a new tab)
   2. Kubernetes Resources Lecture - YouTube link (opens in a new tab)
   3. Go Playground - https://go.dev/play/ (opens in a new tab)
2. Learnings and impressions
   1. I realized that domain knowledge in the field is important to contribute to the project. I wanted to simply contribute to web services, but it was not easy to set up the environment due to lack of knowledge about Kubernetes.
   2. I learned that big open source projects use things like DCO/GPG, and I was able to learn how open source projects are managed and operated.
3. Issues and PR details

• Personal performance
  • Contributing one 'issue' and one 'PR'
• Preparation for Countryview
  • Viewed: OSSCA Basic Training uploaded to YouTube. I've used it a lot before, such as Git and Vim, and I knew the concept, but I was able to know and understand a lot of parts that I didn't know or roughly used.
  • In the 'ArgoWorkflows-OSS/ArgoWorkflows-OSS' repository, we performed an example of Git configuration settings and linking and closing Issue and PR. Argo Workflows must have all commitments signed with gpg private key and signed off when creating PR. Otherwise, it will fail in the GitHub CI. Before I actually contributed to Argo Workflows, it helped me greatly to set up a local Git environment in advance and create a simulated PR.
    • • https://github.com/ArgoWorkflows-OSS/ArgoWorkflows-OSS/pull/38 (opens in a new tab)
  • You have set up the Argo Workflows development environment. At first, I set it up with devcontainer, and then I used Nix. Argo Workflows requires multiple components in the development environment, including React UI, Argo Server, and MySQL, making it difficult to configure the development environment, but we were able to fully configure it over several weeks.
• Countryview progress
  • Fix 'Bug Fix' Fix go build
    • • https://github.com/argoproj/argo-workflows/pull/11635 (opens in a new tab)
    • The existing code base was using Go 1.20, but there was a problem with using Go 1.19 in the Nix build file. Previously, the build was fine, but when I started using the newly added grammar in Go 1.20, I encountered problems with the Nix build.
    • Using '_module.args', I modified Go 1.20 to be the default and modified the Nix build.
  • Automatic update of 'function improvement' Nix go vendor hash
    • • https://github.com/argoproj/argo-workflows/issues/11691 (opens in a new tab)
    • This is an issue that I learned when I set up the development environment during the preparation of the contention. Nix pursues a reproducible build, but when GitHub's Dependency Hash value is not changed together when GitHub's Dependency Abot automatically raises the Go module version.
    • This often requires developers to manually calculate and update Nix's go vendor hash when setting up a development environment, and we are looking for workable ways to improve it.
    • In order to find a solution with the contributors, an issue was created by collecting the contents of existing PRs and Comments.
    • Developers are reflecting it manually without solving it in other open-source projects, so after contributing to Argo Workflows, I think I can contribute to other projects as well.
  • 'Improvement' 'CHANGELOG.md '
    • • https://github.com/argoproj/argo-workflows/pull/11733 (opens in a new tab)
    • Markdownlint is a tool that forces documents in a project to be written in a consistent format and makes them easier to read and modify.
    • Previously, we used Markdownlint to configure the linker settings for the Project Markdown document, but we improved the 'CHANGELOG.md ' file, which is automatically generated using the script, because it does not comply with the linker rules.
    • New 'CHANGELOG.md ' changes created by the changed script are contained in this PR. → → https://github.com/argoproj/argo-workflows/pull/11773 (opens in a new tab)
  • 'Improvement' document style improvement
    • • https://github.com/argoproj/argo-workflows/pull/11787 (opens in a new tab)
    • We've improved the style of some documents that don't follow Markdownlint, and we've shared that we'll revise the documents that are automatically generated later in PR.

refactory

fix: Upgrade Go to v1.21 Fixes #11556[**Merged]**

• Argo Workflows are developed in Go language.
• An issue was issued to upgrade Go Version from 1.20 → 1.21, so we decided to resolve it.
• During the ‘Issue Hackathon’ period, we presented the issue and worked with the same team members to resolve the issue and conduct PR.
• As a result, it was a glorious time to have my first PR and my first contributor badge.

fix: Upgrade Go to v1.21 Fixes #11556 by junkmm · Pull Request #11601 · argoproj/argo-workflows(opens in a new tab) (opens in a new tab)

presentation

• During the Challenges period, we had time to present at an offline meeting the results of CI/CD implementation using Argo Projects.
• It was a useful time to organize my thoughts during the presentation, talk with each other, and understand DevOps and the Argo Project ecosystem.

Issue Hackathon

• An ‘Issue Hackathon’ was held under the leadership of a mentor with the opinion of Da-hye A to reduce entry barriers and motivate contribution activities.
• Under the leadership of our mentor, we became a team with Seongrak, Moonyoung, and Byeongseon.
• During this period, I achieved the resolution of the go 1.20 → 1.21 upgrade issue that I suggested.
• We attempted to resolve the issue of adding Prometheus Metric values built into Argo Workflows, but were discontinued due to the high level of difficulty. However, through this process, I had a great experience breaking down my stereotype that Prometheus requires a separate exporter to be installed and expanding my horizons. plan to add workflow labels to the metric? · Issue #9849 · argoproj/argo-workflows(opens in a new tab) (opens in a new tab)
• We are trying to resolve the following issue: Compile expr in config · Issue #11609 · argoproj/argo-workflows (opens in a new tab)

Beginner’s Special Class - Container Playground

• Argo Workflows is an open source that runs in the Kubernetes native environment.
• The mentor opened the Kubernetes Study, saying that knowledge of Kubernetes would be helpful in approaching our project.
• The first mission was to create a Web Container that satisfied the conditions presented.
• It made me reflect on how I usually write Dockerfiles thoughtlessly, and it was a good time to learn about the relationship between multi-staging, build speed, and how to write Dockerfiles.

Improvements A new feature to support Secrets as a type of parameters (link (opens in a new tab))

The original Argo Workflow allowed you to define arguments directly when passing them to the WorkflowTemplate, or you could set it to reference a ConfigMap. However, unlike other tools that support the common kubernetes ecosystem, the ability to reference Secrets was not supported.

We started getting feature requests https://github.com/argoproj/argo-workflows/issues/5506에서 (opens in a new tab) for this, and we've implemented it and created a Draft PR.

This feature was not easy to develop, especially since it required redefining things like the CustomResourceDefinition interface in Kubernetes, and figuring out the entire lifecycle of how a workflow is created, injected with sidecars, and created as a Pod.

However, as we implemented the feature, we were able to gain a deeper understanding of how workflows are eventually transformed into pods and containers, and the logic behind how workflows templatize context and arguments internally.

Create Issue` Incorrect creator labels on a resubmitted Workflow (link (opens in a new tab))

Argo Workflow has a feature called Resubmit that recreates and runs a Workflow based on the same template. In the case of a resubmitted Workflow, the k8s object label related to the user who created the Workflow was not set based on the resubmitted user, but was set to the existing incorrect value.

As a result, if the user who ran a workflow was different from the user who resubmitted the workflow, the workflow created by the resubmission would have an incorrect workflow creation user-related k8s object label.

We raised an issue about this.

Bugfix: fix: Apply the creator labels about the user who resubmitted a Workflow (link (opens in a new tab))

We created a Pull Request to resolve the issue (bug) we created earlier.

We fixed the bug by labeling the correct Workflow constructor k8s object based on the resubmitted user information only, without considering the information of the existing Workflow executor when resubmitting.

As an example of the change, we showed how a Workflow executed by a user named foo would be resubmitted by a user named bar, and how the creator-related label would be different if it was resubmitted by an unauthenticated user.

We also found that there were a lot of other code that was impacted, so we wrote test code to make it more stable.

Improvements

feature: Propagate creator labels of a CronWorkflow to the Workflow to be scheduled (link (opens in a new tab))

If the CronWorkflow was created by a logged-in user, the CronWorkflow will be labeled with a k8s object for the constructor. However, there was an issue that the k8s object label would not be attached to Workflows that are created periodically based on the settings of CronWorkflow.

Therefore, we have improved Workflows created with CronWorkflow to propagate CronWorfklow's constructor label.

Issue.

Insufficient logging in /oauth2/callback handler when using SSO Authentication (link (opens in a new tab))

We tried to activate the Authentication with Single Sign On (SSO) feature in Argo Workflows using the Identity Provider open source product called Keycloak, but we experienced a significant delay in the activation process due to the lack of logs. Therefore, we opened an issue on the topic of enhancing the logging of the feature activation operation.

Feature.

feature: Improve logging in the oauth2 callback handler (link (opens in a new tab))

This is the pull request that resolved the issue mentioned above (block link (opens in a new tab)). We improved the feature to output error logs for each error case that occurs while using OAuth2 Protocol for SSO.

Also, to make it easier for reviewers to review the pull request, we've added code verification to make the pull request more convincing.

Study`

docs: Add a user named Park Jinsoo (link (opens in a new tab))

At the beginning of the event, we practiced creating a pull request by adding an introduction about myself to the member profile of a repository that my mentor created for us to get acquainted with GitHub.

• individual performance
  • 1 PR Open
• Countryview preparation process
  • We checked the shared video of the basic Git strategy shared by the OSSCA Secretariat and combined the new parts we missed with the existing concepts to enhance our understanding and application of Git.
  • The team's 'ArgoWorkflows-OSS/ArgoWorkflows-OSS' repository allowed us to learn the gpg private keys, issues, PR titles, etc., which are essential for open-source attributes, by actually performing missions and gaining experience.
  • dWe used devcontainer to build and test Argo Workflow's local development environment, and to test the requirements for actually doing the content. The portability tool for multiple library dependencies made it very easy to use.
• Content progress
  • Modifying fields example in formula docs
    • https://github.com/argoproj/argo-workflows/pull/11748 (opens in a new tab)
    • An example of a document that does not use Cron Workflow was included in the 'CronWorkflowSpec' and 'CronWorkflowStatus' fields in the existing official document, causing confusion in finding the required data.
    • So, in the 'CronWorkflowSpec' and 'CronWorkflowStatus' fields, we only allowed examples using CronWorkflow to find the data we needed.

Contribution Activities

Mutex check happens after memoization cache check and lock info missing from UIBug Fix

Issue #11219 (opens in a new tab) PR #11456 - Merged/Included in 3.4.10 release (opens in a new tab)

I managed to modify Argo Workflow to simultaneously utilize the Synchronization and Cache functionalities.

This bug manifested when using both the Synchronization and Memoize keywords in Argo Workflow, causing it not to operate correctly.

The expected behavior was for the Mutex Synchronization to function first followed by the cache, however, after Synchronization occurred, the cache failed to operate.

For instance, when there are job-1 and job-2, if job-1 operates first due to Mutex Synchronization and writes to the cache, job-2 ** should pass without operating, courtesy of the shared cache.**

I was able to fix this by adjusting the sequence of Synchronization and Cache.

While the fix was not complicated, modifying the operation.go, one of the intricate files, allowed me to explore various features of Argo Workflow with many reviews.

Parent level memoization is brokenBug Fix

Issue #11612 (opens in a new tab) PR #11623 - Merged/Included in 3.4.11 release (opens in a new tab)

A new bug arose from the above fix. When using the Memo function in child components rather than at the Template level in Argo Workflow, a bug was reported that caused infinite pending.

I realized that there were unaddressed cases in the tests added in the previous PR. After identifying the cause of the error, I quickly patched it. I included four tests in the PR to detect such exceptions in the future.

UI: workflowDrawer's information link is not correctly workingBug Fix

Issue #11494 (opens in a new tab) PR #11495 - Merged/Included in 3.4.10 release (opens in a new tab)

I fixed an issue where the Information icon link was broken when expanding a workflow on the Argo Workflow dashboard.

I introduced code to prevent incorrect event propagation caused by nested <a> tags. This correction ensured that clicking on the icon now directs users to the correct documentation.

Search by name for WorkflowTemplates in UIFeature Enhancement

Issue #11004 (opens in a new tab) PR #11684 - Merged/Included in 3.4.10 release (opens in a new tab)

This was a collaborative effort with two other contributors.

A helpful feature that allows templates in Argo Workflow to function through name patterns was missing.

We developed an additional feature that lets users search for templates not just by Yaml labels, but also by names. The LIKE search, not just precise naming, will prove useful in the future. Plans are underway to extend this search and pagination functionality to other pages, making this a particularly meaningful PR.

Add more readable Argo CLI installation guide into github documentationDocumentation Contribution

Issue #11750 (opens in a new tab) PR #11751 - Merged (opens in a new tab)

This contribution pertains to the documentation of the Argo CLI, the command-line interface used with Argo Workflows.

The current Argo CLI GitHub documentation lacked installation procedures, making it challenging for first-time users to determine how to install the Argo CLI. Initially, users had to directly navigate to the Release Note or the Quick Start page. By adding an Installation section to the Argo CLI page alongside the existing Usage details, I aimed to enhance user convenience.

Workflow templating is skipped when whitespace is added to template parametersBug Fix

Issue #11767 (opens in a new tab) PR #11781 - Merged (opens in a new tab)

In Argo Workflow, when authoring a workflow template, the placeholder in the form {{parameter}} did not undergo validation when spaces were added, such as {{ parameter }}. The root cause was the internal validation code not trimming spaces before and after the parameter. By adding the trim function to remove spaces, I resolved this issue. This contribution also rectified other placeholder content that previously bypassed validation.

Development Activities

Contributing to the Argo Workflow OSS Common Repo

PR #22 - Merged (opens in a new tab)

I undertook a preliminary exercise for multiple people to contribute to the Argo Workflow. We simultaneously modified new and existing documents with other participants, learning the importance of Git commands and the process of rebasing.

Creating a Web Server with Dockerfile

PR #6 - Merged (opens in a new tab)

This exercise was about creating a Dockerfile that communicates with a local 8080 server and makes it accessible via localhost:8080. We simply crafted a Python server using Flask, and through the Dockerfile, we set up the environment, initiated the server, and connected the port, making the server accessible externally via Docker commands.

Document modification The running-locally (opens in a new tab) part of the official document is not intuitive for people who are new to Dev-container and Makefile, and is broken. There were links, so I uploaded pr #11405 (opens in a new tab) and contributed to editing the official document.

Issue Contribution Although incomplete, this is an issue where secret information can be exposed through commands such as echo within Argo-workflows workflows or Pods within workflows [#8685](https://github.com/argoproj/ (opens in a new tab) argo-workflows/issues/8685), so I tried to solve it.

I invested about 3 hours a day for 4 days, for a total of 12 hours, on this issue, but I have not yet been able to resolve it. (Intermediate commit (opens in a new tab))

• We added ARGO_HIDE_SECRETS, an environment variable that can be injected when running Argo-workflows, across a total of 11 files, and set the option to true by default.
  • The above environment variables can be entered from the command line or added as settings when running Argo-workflows.
  • If you set ARGO_HIDE_SECRETS=false, "You are running with logging include secrets. Be careful." A log saying was recorded.
  • If information corresponding to Secret is included in the workflow or pod log, the code has been modified to mask SecretValue.
    • We wrote test code and verified that the above function works as intended.
    • However, since the above function did not work as intended, I started exploring the process of recording logs. I found out that the logrus (opens in a new tab) library used in the Go language uses io.Writer from the io (opens in a new tab) package. .

Assignment Performance For the Argo-workflows team, the mentor created the OSS-Argo-workflows repository and assigned several tasks.

• In the actual Argo-workflows repo, I learned through assignments how to upload a PR by following the principles (presigned commit, gpg check) that must be followed when uploading a PR, and how to resolve git conflicts.
• In order to upload pr from the actual Argo-workflows repo, modify the code and check whether Argo-workflows is working properly, you must run Argo-workflows with a Dev Container in the local environment. -Our team was given the task of carrying out this process ourselves, and along the way, we helped each other with members who had difficulty performing it. I summarized how to perform the method in a blog post and shared it with my team members.blog (opens in a new tab)

1. Open Source's first contribution

For the first time, I made a documented contribution to ArgoWorkflows. We've fixed the parts on the official site where there's room to confuse whether it's an image or a video, so that users know it's definitely a video. docs: modify demo image in intermediate-inputs.md #11755 (opens in a new tab)

2. Learn how to contribute to open source by watching other members' activities

Through this Open Source Country View Line Academy, I learned how to contribute to open source and how to find issues. The summary is as follows.

• There are many issues than the main logic, or UI parts, or UI parts, or UI parts.
• There are many issues that can contribute to the open source sufficiently, even if you are a professional knowledge of the open source or a practitioner in another field (ex. UI issue)
• When you want to contribute, you first comment that you want to solve this issue directly to the issue and then start working.
• This part was a little strange, but in the case of Argo Workflow, it was a little strange that the person in charge was assigned when making a contribution. Something I don't know? Or, it seems to assign a person in charge when you feel unfamiliar.
• There are many different people. Some people write just one line, and some people write very kindly comments.

I learned how to contribute directly to the issue by looking at other members' issue hackathons. In particular, I found the issue of "Pagination" very interesting among other members' issues. I didn't notice when I was using argo workflow, but I realized that it was possible to contribute to places that could pass by by catching that page-nation is inconsistent and making issues.

3. Development container construction

Personally, I set up the development environment by flying devcontainer myself. In fact, there were countless errors in the process, and I could imagine that other developers would come and squeeze their brains together if there was a bug in practice.

I found out that when you solve dependency issues and later someone else makes an issue on my project, you use development containers to ensure you're working in the same environment, and I thought I'd have to use development containers in other projects I'm working on (discord bot-related projects).

After the interim report, rather than changing my mind a little and feeling intimidated, I wanted to take the opportunity to overhear how other current employees operate the service in practice. In fact, mentees presented various topics, and I was able to hear interesting topics such as load tests and explanations about ebpf in the company. I think it was a very valuable presentation that was hard to hear while attending school.

4. Mastering the Verified Commit method using GPG Sign and uploading the introduction to Team GitHub

Until now, I've been committing without a separate GPG Key, but in the process of uploading the member introduction, I checked the DCObot and GPG and kept getting blocked, so I learned how to create a Verified commit and uploaded the introduction to Team GitHub Repo. In the process, I solved it with the help of the same team member while constantly stopping whenever I committed.

docs: 안지완 프로필 업데이트 (opens in a new tab)

1. Create a beginner's dockerfile

• Create your own web service, build an image via dockerfile, and run a container.
• Build your service using a framework and language of your choice, I used Nest.js.

2. Learn the Nest.js framework

• Nest.js Learning Repository (opens in a new tab)
• Since I only knew the front end, I quickly learned to create a simple API service using the

3. PR after creating the dockerfile

• I created a docker file to build the image, verified that the service is working, and raised a PR, but the build test of the github action fails.
• Remove the --production option and it passes the test, but the image is not optimised. Ask your mentor for advice

• Start troubleshooting based on your mentor's feedback

4. Trouble Shooting

• I tried to install node_modules for production only to reduce the size when creating images with dokerfile, but it didn't pass the github action.
• After a lot of shovelling, I realised that a module called nest-cli is required for nest build, but it was in the devdependency, so I changed it and it worked. (My mentor gave me a hint, but I didn't understand and shovelled it in)
• The reason I was confused was that I had nest-cli installed globally on my MacBook.

5. Open source contributor activity [UI: The position sticky on the workflow toolbar is not working]

• Fixed a bug where the position of the toolbar when selecting a checkbox in the workflows-list was not fixed at the top.
• Read the issue (opens in a new tab)
• Read the PR (opens in a new tab)

[before]

• The top toolbar was not visible when checkboxes were selected and scrolling.
• Fixed an issue with the existing position : sticky not being applied by changing it to position : fixed.

[after]

• After checking a checkbox, you can pin the toolbar to the top of the scroll to fire events for that list without having to scroll further.

[UI - show history about completed runs in each cron workflow]

• Work with a good improvement found by a Uijeong Issue to add a list to the cron-workflows-detail component to view the history of a given workflow.
• Read the issue (opens in a new tab)
• Read the PR (opens in a new tab)

[before]

• There was nothing on the existing cron-workflows-detail page, but the

[after]

• Added a history workflows to the corresponding cron-workflows and an example of when there is no history.
• This PR is still under verification

• Participate in the launching ceremony
• K8s learning
  • Learn Operator concept
  • Helm learning
  • Learning CNI concepts
  • Learning Service Mesh concepts
• Learn Argo Workflows
  • Learn basic usage
    • https://argoproj.github.io/argo-workflows/workflow-concepts/ (opens in a new tab)
    • https://www.youtube.com/watch?v=kxl6wYd5i2g (opens in a new tab)
  • Learn skills around you
    • DevContainer learning
    • Nix Learning
    • https://nixos.org/manual/nixos/stable/ (opens in a new tab)
    • Learning MinIO
    • Learn KeyCloak
• Argo Workflows contribution ‘bug fix’
  • Create issue related to DevContainer malfunction https://github.com/argoproj/argo-workflows/issues/11439 (opens in a new tab)
    • Issue with /etc/hosts entries being deleted when container restarts
  • DevContainer malfunction resolved PR created and merge completed https://github.com/argoproj/argo-workflows/pull/11440 (opens in a new tab)
    • Solved by adding —add-host option to runArgs in devcontainer.json

• Learn technologies around Argo Workflows
  • Install and use NixOS based on what you have learned
  • Research on Argo CD, Argo Events, and Argo Rollout
  • Learn Keycloak
    • Argo Workflows supports Keycloak integration, so I became curious and investigated Keycloak.
    • Learn about the differences between OAuth2 and OIDC
    • Learn about Keycloak concepts -Role -Ream -Client
    • Learn how to set up Keycloak
    • Learn about Keycloak API and integration methods
    • Study Keycloak official documentation
      • https://www.keycloak.org/docs/latest/securing_apps/index.html (opens in a new tab)
      • https://www.keycloak.org/docs-api/22.0.1/rest-api/index.html (opens in a new tab)
    • Practice installing and using Keycloak yourself

lint test 1. how to use Git & Commit, PR rules

• Tasked with mastering basic Git usage and sending strict commits and pull requests for contributions.

• In the official Argo Workflow project, it was helpful to use the Issue Template and send a PR for the issue you want to contribute to, and it was also an opportunity to learn about the existence of the Issue Template.

• It was an opportunity to indirectly experience the elements essential for future contributions.

  • PR naming convention (opens in a new tab)
  • DCO Bot Check (opens in a new tab)
  • GPG Commit (opens in a new tab)
  • Commit Message convention (opens in a new tab)
  • Link issues and PR (opens in a new tab)

• Issue creation - Member profile update - PR - Review - Merge process

  

2. Participate in a special beginner class - Repository for beginner special class missions(container-playground) (opens in a new tab) - The purpose was to help people who are unfamiliar with Docker or Kubernetes or who are new to it.

• Learn about the need for Docker Image optimization while performing tasks presented by a mentor

  • Since it is a process of stacking certain packages and static files by layer from the From clause, we realized that optimization is essential because the Docker image can become heavy and have a negative impact on performance improvement.

• Mission

  ❗️objective❗️
  
  Create your own web service and write a Docker file that can be containerized.
  
  To pass the assignment, please be sure to follow the instructions below.
  
  • Directory and file placement
      • Be sure to create your own github account directory for your own service and write it there.
      • The `Dockerfile` must be located at the top of your directory. (If this condition is not achieved, CI will fail.)
      • As long as it is under your own directory, you can freely write the rest of the files except for the location of `Dockerfile`.
      • However, the image must be built successfully when you execute the command `docker build -t [image name] .` at the top of your directory.
  • Behavior of built images
      • Your web service must operate on port 8080.
      • The built image must be serviced without problems when run with `docker run -d -p [forwarding port number]:8080 [image name]` without any additional parameters.
  • Web service development language and service structure
      • It doesn’t matter which language or framework you prefer.
      • It doesn't matter if you create a simple API service with no UI or design.
      • However, you must create two required APIs. (I don't care about the response value.)
          1. /api/v1/[your github account]
          2. /healthcheck
  • (Optional) It would be better to optimize the Docker image.([참고](https://thearchivelog.dev/article/optimize-docker-image/))
  • [How to link PR and issues using keywords](https://docs.github.com/ko/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an Please refer to -issue-using-a-keyword) to connect the issue and PR. (Manual connection x)
  
  ❗️Note❗️
  
  •It would be a good idea to refer to the documents below to understand Docker concepts and write a Dockerfile.
  
      • [Official documentation for creating a Dockerfile](https://docs.docker.com/engine/reference/builder/)
      • [How to use Docker for beginners](https://mysetting.io/slides/xxj85vnvey) (Content related to Docker Toolbox has been deprecated)
  
  •To raise PR and merge, please refer to the points below.
  
      • Since you do not have permission to create or push branches in the repo, you must fork and then work on it.
      • Please refer to [PR's naming convention](https://flank.github.io/flank/pr_titles/).
      • [DCO](https://github.com/apps/dco) Please commit while referring to the conditions for passing the bot's check.
      • Please understand how to commit using [GPG](https://www.44bits.io/ko/post/add-signing-key-to-git-commit-by-gpg) and create a signed commit.
      • It would be good if [Commit Message Convention](https://www.conventionalcommits.org/en/v1.0.0/) could also be applied. Even if you don't have to follow it, please avoid making commit messages that are too meaningless. (Optional)```
  

• Having previous experience with the Python-based Django framework, I wrote a Docker file that creates a Django REST API.

• I sent out a PR, but was pointed out a security issue or an error in unnecessary package import syntax.

  

• This is the first time I learned that SECRET_KEY is exposed in the settings.py code of the Django project, and I will take the time to think about how to solve this security issue.

  • We created a .json file containing the secret key and proceeded to refer to the json file in settings.py.
  • Since the secret.json file cannot be uploaded to Commit, I learned how to ignore the json file through .gitignore, and was able to ignore unnecessary files created after executing certain commands such as dbsqlite3.
  • It was an experience that made me realize that several considerations are needed to upload locally developed results to a Git project.

3. Argo Workflow Contributor

• While looking into Argo Workflow, I came across the Argo Workflow Slack channel marked Deprecated in the Argo Workflow - Contact - Help field.

• I thought it was a minor UI Issue, but I thought it was an opportunity to check what language the UI is displayed in and how it was developed, so I raised an issue and submitted a PR.

  

  • Created Issue

    UI: non-existent Slack Workspace link on help page Issue (opens in a new tab)

    

    • When I created an issue, the Maintainer of the Argo project quickly left a comment.

    • I randomly tried to fix it with the CNCF Argo Channel link, but I received a comment from the maintainer asking me to update it with a different link.

  • Created PR

    fix: deprecated Link(Help-Contact) Issue (opens in a new tab)

    

    • Argo Workflow had a UI based on React, and the directories were arranged by component, making it easy to analyze the code.

    • I didn't pass the DCO bot test because I accidentally omitted the Signed-off option during Commit

      • but I learned about the ability to revert previous commits (Rebase) or merge multiple unnecessary commits into one (Squash) in GIt. And I returned the previous commit and committed it with git commit -S -s -m "Commit Message".

    • I looked up what the comment ‘LGTM’ meant, and on Google, I used the tag LGTM to express my opinion. 'Looks Good To Me'. In other words, it was a rewarding experience because it meant it looked good.

    • The process of finding bugs or modifying the UI is important, but I think the most important thing is the process of performing contributions according to the rules set by the Argo Workflow ecosystem.

4. Participating in Argo Workflow Hackerton (Argo workflow - Hackathon held within the OSSCA team)

• Pull Request(Merged) : feat: Search by name for WorkflowTemplates in UI (opens in a new tab)

• Issue : Search by name for WorkflowTemplates in UI (opens in a new tab)

• Issue Hackathon activity period

  • 1st Hackathon (Hackathon Group C) : 23.08.16 - 23.08.20

  • 2st Hackathon (Hackathon Group C) : 23.08.20 - 23.08.27

    

    • Issue content

      • When there are a large number of templates in a cluster, it is good to search by name, but scrolling through all the templates is always inconvenient due to the lack of a search function.
      • It was thought that the Argo Workflow UI needed a function to filter the results of workflow templates by name, so the issue was adopted as a result of a group meeting.

    • Role

      • Front-End
        • Creating a search field (Bar) in Argo workflow Template UI
        • Analyze .get logic to analyze where the Name Pattern (Like search) is sent
        • Modify workflow-template-filter.tsx and workflow-template-list.tsx in the workflow-template component directory.

    • Meeting details

      • The meeting is held through the Slack hackathon channel, where opinions and information are shared every day.
      • 1st Meeting details

      1. name search function (backend)
      
          • WorkflowTemplate page
          • Add name search (LIKE search)
          • ClusterWorkflowTemplate page
          • Add name search (LIKE search)
          • CronWorkflow page
          • Add name search (LIKE search)
      
      
      
      2. name search function (frontend)
      
          • WorkflowTemplate page
          • Add name search ui
          • ClusterWorkflowTemplate page
          • Add search sidebar (name, label)
          • CronWorkflow page
          • Add name search ui
      
      3. pagenation (frontend)
      
          • WorkflowTemplate page
          • pagination based on name
          • ClusterWorkflowTemplate page
          • Add pagination
          • CronWorkflow page
          • Add pagination
      
      4. Write test code
      
          - name search (LIKE search)
          - Need more analysis on what test code should be written

      • 2nd discussion content

        • 1st offline meeting

          

      1. Co-commit method
      
          •  Clone the repository https://github.com/ArgoWorkflows-OSS/argo-workflows locally.
          • We create a branch in the repository for our team to work on. (`master` vs `release-3.4.10`)
          • Work on the functions you are responsible for in the corresponding branch of the repository. (Commit by carefully following the commit rules for raising PR.)
          • When everyone's work is completed, 1 out of 3 people will send out a PR according to the PR template.
          • All 3 people can be contributors
      
      2. Since it is a hackathon and there is a set period, we decided to first implement the workflow-template name filter, which we think is the main one among workflow-template, cluster-workflow, and cron-workflow, send a PR, and move on once the maintainer merges it.
      
          • Roles for each part
      
          • Back-End
      
              • workflow_template_server.go
                  • Name filtering and pagination recalculation
      
          • Front-End :
      
              • workfflow-template-filter.tsx
                  • Add Name search UI
                  • Receiving and filtering the Name argument
              • workflow-template-list.tsx
                  • Add Name state
                  • Pass name to userEffect list
              • workflow-template.tsx, Utils.tsx
                  • Passing the Name argument

      • 3rd discussion details

        • 2nd offline meeting

          

           1. Offline Meeting Meeting Contents
        
               • An opinion that even cases where there is no namespace should be included in the filter. (Insufficient grounds to say to eliminate namespace - Other sites (Kubernetes Dashboard, OpenShift, Argo CD, etc.) also provide namespace without namespace)
               • Thoughts on whether it is possible to import and apply the logic used in continue and whether continue can be maintained as is even with custom results.
               • After analyzing the continue logic until Wednesday night, if it is concluded that pagination using continue is not possible, upload a question in the issue comment.
               • Front-end pagination (data is not reloaded, the method used in argocd) vs. server-side pagination (pagination after checking the entire list each time, will the load be okay?)
               • If server-side caching is implemented, is there a place to store it?
           2. I decided to do a full K8s search by applying only the namespace and label every time I turned the page.
        
           3. Additional logic implemented in offset-based pagination method
               • The part that didn't work
                   • If you perform a filtered search after clicking the next page button, no data appears even if there are search results.
                   • If you increase the number of pagination after clicking the next page button, the search results do not display properly.
               • What changed
                   • As the continue value is updated on the server, when increasing the number of pages or applying filtering, there is a problem with pagination based on the continue value already set on the server.
                   • A method of changing the continue value to be passed from the front was adopted ( When increasing the number of pages or applying filtering, set continue back to 0)
        
        
           4. Pagination Test
               • workflow_template_server_test.go passed
               • (14 workflow templates registered)
               • Normal : UI workflow template first page
               • Normal : when workflow template page limit is 5, 10, 50
               • Workflow template page Add workflow template on page 1 and move to page 2
               • Workflow template page Delete the workflow template from page 1 and move to page 2
               • Test the above with `name pattern` filtering search
               • Search without name pattern and then re-search by adding name pattern
               • After searching including the name pattern, deleting the name pattern and searching again
        
           5. Create PR

      • Like filter (Name Pattern) implementation

        • ex) Workflow-template starting with sp can be searched

          

      • Result

        

        • The implementation was a success, and we plan to modify the previously discussed cluster-template and cron-template components.

5. Learning outside of contribution activities - Completion of Google Kubernetes Study Jam training - Badge (opens in a new tab) - Architecting with Google Kubernetes Engine: Foundations Earned 7월 18, 2023 EDT - Architecting with Google Kubernetes Engine: Workloads Earned 7월 26, 2023 EDT - Architecting with Google Kubernetes Engine: Production Earned 8월 4, 2023 EDT

• The organized contents are recorded on a personal blog (velog) euijoo's Velog GCP Series (opens in a new tab)

✅ Records about Contribution

Series | 2023 OSSCA - ddubi.log (opens in a new tab)

-> Unfortunately It is not translated..

✅ Various tasks

1. The task regarding issue/commit/PR in Github

   [Summary]

   

   • Select the profile update issue, fork ArgoWorkflows-OSS repository, and commit it by adding users.md and [name].md under docs/user in the repository. After that, link the issue and submit a PR.

   [Outcome]

   docs : update UiJeong Profile by juijeong8324 · Pull Request #19 · ArgoWorkflows-OSS/ArgoWorkflows-OSS (opens in a new tab)

   records: Github에서 issue/commit/PR (opens in a new tab)

2. Running Locally

   [Summary]

   • Running Argo workflows locally
   • Install Linux on Windows with wsl2 and run argo workflows using devcontainer cli.

   [Outcome]

   records: Argo Workflows running locally (opens in a new tab)

   records: Argo Workflows running locally - retry (opens in a new tab)

   records: Argo Workflows running locally - final (opens in a new tab)

   records: Argo Workflows running locally - real final (opens in a new tab)

3. Special class for Beginners - Create my own service container image

   

   [Summary]

   • Special class for Beginners is a class for beginners(It's me) who don't know much about Container, kubernetes, argo from Argo-workflows oss team.
   • The task is creating my own web service, writing dockerfile for containerize the application.
   • You need to understand Dockerfile, docker, images, and containers.
   • In my case, build web server with express and write dockerfile.

   [Outcome]

   code: About task (opens in a new tab)

   records: 왕초보 특별반 - 1. 나만의 서비스 컨테이너 이미지 제작 (opens in a new tab)

   records: [Docker] Dockerfile 기본 명령어에 대해 알아보자 (opens in a new tab)

✅ Offline meeting

✅ Searching Issue & Creating Issue

• Issue #11131 (opens in a new tab) Fix Bug

  [Summary]

  Error occurs when " in a workflow input parameter fails to escape and is referenced as workflow.parameter.json

  [Outcome]

  I dissmiss this issue because of the eeror occured from python environment not argo workflows.

  records: Argo Workflows - Issue #11131 (opens in a new tab)

• Issue #11706 (opens in a new tab) Improve UI

  [Summary]

  An issue that would like to add a UI that can check the history of each workflow in the cron workflow tab.

  records: Argo Workflows - Issue #11706 (인생 처음으로 올린 감격적인 나의 소중한 Issue) (opens in a new tab)

  [Outcome]

  PR #11811 (opens in a new tab) Closes

✅ PR open & merge

• PR #11732 (opens in a new tab) docs PR Merge

  [PR Summary]

  PR that modifies the image in the Argo Workflows official document to clearly show that the image in Artifact Visualization is a YouTube video link.

  

  [Outcome]

  records: Argo Workflows - PR #11732 docs: Add description about img in artifact-visualization.md (opens in a new tab)

  Image replacement to add a play button to the center of the image

  merge complete

• PR #11811 (opens in a new tab) Improve UI PR Merge

  [PR Summary]

  The PR tries to solve Issue #11706 (opens in a new tab)

  Modify to check completed cron-workflow when you click specific cron-workflow at cron workflow page

  If it cannot find a completed cron-workflow, it will be display like above

  [Outcome]

  Merge Complete

1. git/github Getting Started issue: https://github.com/ArgoWorkflows-OSS/argoworkflows-oss.github.io/issues/11 (opens in a new tab)
   pr: https://github.com/ArgoWorkflows-OSS/argoworkflows-oss.github.io/pull/15 (opens in a new tab)
   summary: Familiarize yourself with git/github, the core of code shape management in the open source ecosystem.
   detail:
   Much of the open source world relies on git and github for collaboration.
   Therefore, in order to contribute to open source, it is necessary to familiarize yourself with git/github.
   Using git/github, it was a hands-on activity to issue issues, follow commit rules, and create PRs.

2. feat: logging for client-side throttling

   issue: #11387 (opens in a new tab), #11402 (opens in a new tab)
   pr: #11437 (opens in a new tab)
   summary: fix to figure out faster if user set certain options incorrectly
   detail:
   It uses a library called client-go to communicate with kubernetes.
   This library provides options --qps, -burst for request limit.
   If this option is set very low, it will cause throttling. That's why we have a separate log level to inform the user more quickly.
   While working on this issue, I learned a lot about client-go, especially about RoundTrip.
   It was a shock when I realized that I could add middleware using RoundTrip for any object that respects the http request interface provided by golang.

3. go 1.21 upgrade

   issue: #11566 (opens in a new tab)
   pr: #11601 (opens in a new tab)
   summary: golang 1.21 ver release에 따른 version upgrade 진행
   detail: As a lead mentee, I decided it would be better to have a teammate who hasn't contributed yet try to solve the issue rather than me.

   

   I shared the issue with my teammate, and I was able to support him in successfully resolving the issue.
   We shared our approach to the issue in our regular weekly meeting.

   

   On weekdays, we would take questions and answer them separately in a slack channel so that everyone on the team could get experience submitting PRs.

   

   Team members also gained invaluable experience merging PRs.

4. Debugging 설정

   summary: 팀원의 argo-workflow debugging setting
   detail:
   For team members who are new to developing with golang, we had some difficulties setting up the debugging environment, and we worked together to solve it.

   

   During this process, I realized that I'm not very good at setting up debugging for apps that are closely related to kubernetes, and I realized that I needed to get some help with that.

Multiple Tasks

• Github Issue/Commit/PR Mission
  • Learned how to use Github to contribute the ArgoWorkflow which is a large scale of open source community.
  • https://github.com/ArgoWorkflows-OSS/argoworkflows-oss.github.io/issues/43 (opens in a new tab)
  • https://github.com/ArgoWorkflows-OSS/argoworkflows-oss.github.io/pull/44 (opens in a new tab)
• ArgoWorkflow Running Locally
  • Run ArgoWorkflow in local environment
  • Understanding Argo Workflow Structure, DevContainer, Container-Based Applications, and Makefile Structure
• Make a container image
  • Learned Docker File Command, Docker layer structure, optimization and caching
  • https://github.com/ArgoWorkflows-OSS/container-playground/pull/16 (opens in a new tab)
  • https://github.com/ArgoWorkflows-OSS/container-playground/pull/23 (opens in a new tab)

Issue analysis

• Metric issue analysis
  • Analysis of issues that require improvement by many users due to issues with many Github Reactions
    • Increased monitoring convenience by adding metric labels
  • As a result of issue analysis, it was discovered that developing the content could cause another problem.
    • When adding a metric label, a large amount of metrics are collected, which may cause performance problems due to a large amount of metric traffic flowing to existing users.
  • Suggest and communicate ways to solve problems by detouring
    • Confirm that the monitoring requested by the issue is possible when using a custom metric, and suggest a way to resolve it by bypassing it.
    • https://github.com/argoproj/argo-workflows/issues/9849#issuecomment-1685227337 (opens in a new tab)
  • Inquire some ambiguous part in the comment in code for future improvement.
    • https://github.com/argoproj/argo-workflows/pull/8486#discussion_r1306700745 (opens in a new tab)
  • Issue analysis through issue hackathon

Contribute

• Fixed a type of function name and vaiable name
  • Fixed parts that could cause confusion to other developers
  • https://github.com/argoproj/argo-workflows/pull/11604 (opens in a new tab)
  • https://github.com/argoproj/argo-workflows/pull/11633 (opens in a new tab)
  • https://github.com/argoproj/argo-workflows/pull/11687 (opens in a new tab)

1. Cron workflow can not apply volumeClaimTemplates config from argo controller config map (workflowDefaults)

Issue #11344 (opens in a new tab) PR #11662 (opens in a new tab)

Issue Analysis

To understand this issue, I first needed to grasp what Default Workflows (opens in a new tab) are.

I learned that the workflowDefaults field in the argo workflows controller configmap allows you to set default values for workflows. Additionally, I discovered that if a workflow already has values for this field, those values take precedence.

For example, after configuring the configmap as follows, when you create a Workflow,

# This file describes the config settings available in the workflow controller configmap
apiVersion: v1
kind: ConfigMap
metadata:
  name: workflow-controller-configmap
data:
  # Default values that will apply to all Workflows from this controller, unless overridden on the Workflow-level
  workflowDefaults: |
    metadata:
      annotations:
        argo: workflows
      labels:
        foo: bar
    spec:
      ttlStrategy:
        secondsAfterSuccess: 5
      parallelism: 3

it will be automatically created with the values set in the workflowDefaults field, like this:

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: gc-ttl-
  annotations:
    argo: workflows
  labels:
    foo: bar
spec:
  ttlStrategy:
    secondsAfterSuccess: 5 # Time to live after workflow is successful
  parallelism: 3

The issue was related to an error occurring when adding the volumeClaimTemplates value to workflowDefaults, causing errors when creating CronWorkflows or Workflows.

The error message indicated, does not contain declared merge key: name.

Upon checking the code, it was found that the error occurred in the StrategicMergePatch function, which is related to Kubernetes' patch strategy.

VolumeClaimTemplates []apiv1.PersistentVolumeClaim `json:"volumeClaimTemplates,omitempty" patchStrategy:"merge" patchMergeKey:"name" protobuf:"bytes,6,opt,name=volumeClaimTemplates"`

The issue arose from the fact that the VolumeClaimTemplates type defined in Workflows used name as the patchMergeKey.

However, upon inspecting the PersistentVolumeClaim type below, it was found that name was not present. In other words, the problem occurred because a value was defined as the patchMergeKey that was not part of the structure.

type PersistentVolumeClaim struct {
	metav1.TypeMeta `json:",inline"`
	// Standard object's metadata.
	// More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
	// +optional
	metav1.ObjectMeta `json:"metadata,omitempty" protobuf:"bytes,1,opt,name=metadata"`
 
	// spec defines the desired characteristics of a volume requested by a pod author.
	// More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes#persistentvolumeclaims
	// +optional
	Spec PersistentVolumeClaimSpec `json:"spec,omitempty" protobuf:"bytes,2,opt,name=spec"`
 
	// status represents the current information/status of a persistent volume claim.
	// Read-only.
	// More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes#persistentvolumeclaims
	// +optional
	Status PersistentVolumeClaimStatus `json:"status,omitempty" protobuf:"bytes,3,opt,name=status"`
}

Issue Resolution

I removed the patchMergeKey from VolumeClaimTemplates.

However, the reason patchMergeKey was added to VolumeClaimTemplates was to maintain consistency with conventions used for Volumes.

Since this issue is related to policies, it indeed requires further discussion.

This was my first PR to the ArgoWorkflows project, and it's great that i was able to identify the cause of an issue that was causing inconvenience for many people.

2. Search by name for WorkflowTemplates in UI

Issue #11004 (opens in a new tab) PR #11684 (opens in a new tab)

Issue Analysis

This issue was worked on by a team of three people.

WorkflowTemplates do not have a search function based on 'name', so to find a specific WorkflowTemplates, you could only search based on label.

So, many users were feeling inconvenienced, and it was an issue related to 'feature improvement' that they would like to provide a function to search based on 'name'.

Issue Resolution

We added additional logic to filter the results of WorkflowTemplates retrieved through the Kubernetes API based on their 'name', successfully implementing this feature.

However, there was one issue.

Existing pagination was implemented using Kubernetes' own continue value, so if Kubernetes results were custom manipulated like this, Kubernetes pagination could not be used.

We had a lot of concerns about how to solve this, but We solved the problem by applying logic to implement cursor pagination using Kubernetes' resourceVersion.

It was so fun to be able to discuss it with others instead of alone.

I also felt good about providing some really needed functionality to the ArgoWorkflows project.

3. A problem that is not initialized when changing the number of page limits

Issue #11702 (opens in a new tab) PR #11703 (opens in a new tab)

Issue Analysis

While resolving the Search by name for WorkflowTemplates in UI issue, i discovered a new pagination bug.

When changing the number of pages, the continue value used for pagination was not initialized in the UI, so the data was not displayed properly.

Issue Resolution

I was able to solve the problem by simply modifying the logic to initialize offset when a change in page number is detected in the UI code.

It was only a one-line code change, but this one line solved a problem that was quite inconvenient.

4. Pagination may not work correctly for archived workflows

Issue Analysis

Issue #11715 (opens in a new tab) PR #11761 (opens in a new tab)

This issue was directly communicated to us by Maintainer @terrytangyuan through Slack.

It felt like I was contacted by my favorite celebrity and I was so happy that I almost flew away. I suppressed my happy and excited heart and analyzed the issue.

Workflows and ArchivedWorkflows were previously separated into different pages, but starting from the master version, Workflows and ArchivedWorkflows are combined into one page, and the logic has been modified to show ArchivedWorkflows together if they exist.

However, when Workflows and ArchivedWorkflows were merged into one, a problem occurred with pagination.

The two resources also used completely different pagination. Workflows was using the continue value, which is Kubernetes' own pagination, and ArchivedWorkflows used its own database, so it was using the database to perform pagination using the offset method.

However, while passing the continue value used in Workflows to ArchivedWorkflows as is, a problem occurred where ArchivedWorkflows was not searched at all.

Issue Resolution

I was able to resolve the issue by referring to the pagination logic that was implemented while resolving the Search by name for WorkflowTemplates in UI issue.

Since the two resources have no choice but to use different methods of pagination, rather than using pagination before merging the two resources, use a method of first searching the entire resource and merging the two resources and finally applying the pagination logic. I did it.

I was able to solve the problem of ArchivedWorkflows not being searched, but fetching and merging the entire list every time the page is changed is a performance concern, so i'm thinking about a way to test performance.

I plan to switch to front-end pagination if performance testing indicates that it's not working well.

It was great to be able to solve a critical issue, and I felt proud and fun because I felt like I was contributing properly to the ArgoWorkflows project as a contributor.

5. Relocation of Commit Guidelines Information in the Documentation

Issue #11700 (opens in a new tab) PR #11701 (opens in a new tab)

Issue Analysis

The ArgoWorkflows project has a README document for developers attempting to contribute.

However, it does not mention specific guidelines for commits.

@GeunSam2 mentor mentioned that it was inconvenient when initially attempted to contribute and had difficulty finding commit guidelines.

Issue Resolution

Upon hearing this feedback, I made a modification to the contribution README by adding a link to commit guidelines.

This change aims to make it easier for developers who want to contribute to ArgoWorkflows.

In this PR, a maintainer provided a code suggestion, which was intriguing and enjoyable for me as I was encountering the code suggestion feature for the first time.